Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On current master (
30f38c8d8728ee99a2194bc7a2c5f556cb6a0a3a
) with Rust 1.82 (rustc 1.82.0 (f6e511eec 2024-10-15)
,cargo 1.82.0 (8f40fc59f 2024-08-21)
), runningcargo check --all-features --tests
emits the following warning:This PR fixes that and also does some other, opportunistic cleanup in the same file:
new
andrewind
methods#[allow(dead_code)]
annotation onnew_buffered
to more specific feature-gatingNote on the second point: from searching through the project for the string
new_buffered
, it is called solely fromhyper-util/src/server/conn/auto/mod.rs
on lines 144, 150, and 285.#[cfg(feature = "http1")]
and#[cfg(feature = "http2")]
respectivelyserver::conn::auto
module itself is feature-gated with#[cfg(any(feature = "http1", feature = "http2"))]
server
module is of course feature-gated with#[cfg(feature = "server")]
.I confirmed that in this branch that the following commands succeed without warnings:
cargo check cargo check --all-features cargo check --all-features --tests cargo check --features http1 cargo check --features http2 cargo check --features http1,http2 cargo check --features http1,http2,server cargo test --all-features